Bug 270920

Summary:	[webkitcorepy] Exit AutoInstall.install when disabled
Product:	WebKit	Reporter:	Jonathan Bedard <jbedard>
Component:	Tools / Tests	Assignee:	Jonathan Bedard <jbedard>
Status:	RESOLVED FIXED
Severity:	Normal	CC:	webkit-bug-importer
Priority:	P2	Keywords:	InRadar
Version:	WebKit Nightly Build
Hardware:	Unspecified
OS:	Unspecified

Jonathan Bedard

Reported 2024-03-13 11:19:15 PDT

We should early exit AutoInstall.install if the AutoInstaller is disabled. Callers of this function may be expecting side-effects, so we should also log a message when we encounter this situation.

Attachments
Add attachment proposed patch, testcase, etc.

Radar WebKit Bug Importer

Comment 1 2024-03-13 11:20:41 PDT

<rdar://problem/124542328>

Jonathan Bedard

Comment 2 2024-03-13 11:27:40 PDT

Pull request: https://github.com/WebKit/WebKit/pull/25828

EWS

Comment 3 2024-03-13 16:32:30 PDT

Committed 276051@main (f657af17ad3a): <https://commits.webkit.org/276051@main> Reviewed commits have been landed. Closing PR #25828 and removing active labels.

EWS

Comment 4 2024-03-14 08:43:59 PDT

Committed 272448.732@safari-7618-branch (88863e8f5c53): <https://commits.webkit.org/272448.732@safari-7618-branch> Reviewed commits have been landed. Closing PR #1129 and removing active labels.

Note You need to log in before you can comment on or make changes to this bug.