Bug 27092 – media controller shouldn't scale its text element when text only zoom is being used.

• Component: New Bugs
• Status: RESOLVED FIXED

[Pierre d'Herbemont]

media controller shouldn't scale its text element when text only zoom is being used.

<rdar://problem/7037987>

[Dave Hyatt]

Created attachment 257104 [details]
Patch

[WebKit Commit Bot]

Attachment 257104 [details] did not pass style-queue:


ERROR: Source/WebCore/css/StyleBuilderCustom.h:742:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/WebCore/css/CSSComputedStyleDeclaration.cpp:3185:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/WebCore/css/CSSParser.cpp:2361:  One space before end of line comments  [whitespace/comments] [5]
ERROR: Source/WebCore/css/CSSParser.cpp:2368:  One space before end of line comments  [whitespace/comments] [5]
Total errors found: 4 in 21 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Dave Hyatt]

Created attachment 257106 [details]
Patch

[Simon Fraser (smfr)]

Comment on attachment 257106 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=257106&action=review

> Source/WebCore/rendering/style/RenderStyle.h:1375
> +    void setTextZoom(TextZoom v) { SET_VAR(rareInheritedData, m_textZoom, v); }

'v' could have a better name.

[Build Bot]

Comment on attachment 257106 [details]
Patch

Attachment 257106 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/6549306244857856

New failing tests:
fast/text/wbr-styled.html
fast/text/textIteratorNilRenderer.html
fast/text/unicode-variation-selector.html
fast/text/trailing-white-space-2.html
fast/text/wbr-pre.html
fast/text/wbr-in-pre-crash.html
fast/text/wbr.html
fast/text/trailing-white-space.html
fast/text/wide-zero-width-space.html
fast/text/vertical-rl-rtl-linebreak.html

[Build Bot]

Created attachment 257115 [details]
Archive of layout-test-results from ews102 for mac-mavericks

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews102  Port: mac-mavericks  Platform: Mac OS X 10.9.5

[Dave Hyatt]

Fixed in r187110.

[Dave Hyatt]

Before this gets backed out, I do not believe any of these WK1 failures are legit. The tests pass when run individually, and when you look at the failures they are colorspace differences and/or font rendering differences.

I think the test harness for WK1 is buggy here.

[Jon Lee]

Test failures were addressed in 187120.