Bug 27089

Summary:

Fix V8 idl codegen to use unique constant names

Product:

WebKit

Reporter:

Marc-Antoine Ruel <maruel>

Component:

WebKit Misc.

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

abarth

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
Fix to use a DerivedSource.cpp-like cpp merger for v8 bindings	abarth: review+

Marc-Antoine Ruel

Reported 2009-07-08 12:43:14 PDT

Embed the interface name in the global constant names so coagulating all the .cc files into one compile unit works with V8 bindings.

Attachments
Fix to use a DerivedSource.cpp-like cpp merger for v8 bindings (2.47 KB, patch) 2009-07-08 12:45 PDT, Marc-Antoine Ruel	abarth: review+	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Marc-Antoine Ruel

Comment 1 2009-07-08 12:45:51 PDT

Created attachment 32466 [details] Fix to use a DerivedSource.cpp-like cpp merger for v8 bindings

Adam Barth

Comment 2 2009-07-08 13:28:18 PDT

Comment on attachment 32466 [details] Fix to use a DerivedSource.cpp-like cpp merger for v8 bindings LGTM

Adam Barth

Comment 3 2009-07-08 13:33:22 PDT

Sending WebCore/ChangeLog Sending WebCore/bindings/scripts/CodeGeneratorV8.pm Transmitting file data .. Committed revision 45632.

Note You need to log in before you can comment on or make changes to this bug.