Bug 270883
| Summary: | [UnifiedPDF] WebCore::DataDetectorHighlight should be decoupled from the page | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Abrar Rahman Protyasha <a_protyasha> |
| Component: | Assignee: | Abrar Rahman Protyasha <a_protyasha> | |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | a_protyasha, thorton, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Abrar Rahman Protyasha
Currently, DataDetectorHighlight instances require a WebCore::Page object at construction time. This is inconvenient when trying to fit this data type into the UnifiedPDF Data Detection code paths. We should instead offload the work required from WebCore::Page to the DataDetectorHighlightClient virtual interface, which various overlay controllers can implement (and call into Page, if need be, for implementation support)
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/124490748>
Abrar Rahman Protyasha
Pull request: https://github.com/WebKit/WebKit/pull/25799
EWS
Committed 276060@main (c4304291691c): <https://commits.webkit.org/276060@main>
Reviewed commits have been landed. Closing PR #25799 and removing active labels.