Bug 270865

Summary:	Always use DDHighlightCreateWithRectsInVisibleRectWithStyleAndDirection in DDHighlight creation code
Product:	WebKit	Reporter:	Abrar Rahman Protyasha <a_protyasha>
Component:	Platform	Assignee:	Abrar Rahman Protyasha <a_protyasha>
Status:	RESOLVED FIXED
Severity:	Normal	CC:	a_protyasha, webkit-bug-importer
Priority:	P2	Keywords:	InRadar
Version:	WebKit Nightly Build
Hardware:	Unspecified
OS:	Unspecified

Abrar Rahman Protyasha

Reported 2024-03-12 10:55:42 PDT

Currently, we call DDHighlightCreateWithRectsInVisibleRectWithStyleAndDirection conditional on HAVE(DD_HIGHLIGHT_CREATE_WITH_SCALE). This is not necessary because all calls to the DDHighlight creation method happen in macOS-only codepaths, and the method in question is available on all supported macOS configurations.

Attachments
Add attachment proposed patch, testcase, etc.

Radar WebKit Bug Importer

Comment 1 2024-03-12 10:56:13 PDT

<rdar://problem/124465778>

Abrar Rahman Protyasha

Comment 2 2024-03-12 12:09:00 PDT

Pull request: https://github.com/WebKit/WebKit/pull/25784

EWS

Comment 3 2024-03-12 15:15:48 PDT

Committed 276001@main (0df9914623bb): <https://commits.webkit.org/276001@main> Reviewed commits have been landed. Closing PR #25784 and removing active labels.

Note You need to log in before you can comment on or make changes to this bug.