Bug 27084

Summary: Add -[WebView _ isProcessingUserGesture]
Product: WebKit Reporter: Greg Bolsinga <bolsinga>
Component: WebKit Misc.Assignee: Greg Bolsinga <bolsinga>
Status: RESOLVED FIXED    
Severity: Normal CC: darin, ddkilzer
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: Mac (Intel)   
OS: OS X 10.5   
Attachments:
Description Flags
patch to implement bug fix
none
updated to address Darin's comments darin: review+

Greg Bolsinga
Reported 2009-07-08 10:56:50 PDT
Some platforms need to know if a WebView is in the midst of a user gesture or not. <rdar://problem/7038294>
Attachments
patch to implement bug fix (2.99 KB, patch)
2009-07-08 11:05 PDT, Greg Bolsinga 		no flags
DetailsFormatted DiffDiff
updated to address Darin's comments (5.39 KB, patch)
2009-07-08 13:18 PDT, Greg Bolsinga 		darin: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Greg Bolsinga
Comment 1 2009-07-08 11:05:50 PDT
Created attachment 32460 [details] patch to implement bug fix
Darin Adler
Comment 2 2009-07-08 11:07:47 PDT
Comment on attachment 32460 [details] patch to implement bug fix The word "hint" here is very strange. Can we come up with a more sensible name for this?
Greg Bolsinga
Comment 3 2009-07-08 11:09:09 PDT
"hint" is what it is called in WebCore; that's why I used it!
Darin Adler
Comment 4 2009-07-08 11:59:06 PDT
(In reply to comment #3) > "hint" is what it is called in WebCore; that's why I used it! Of course. My point is that an internal name inside WebCore can easily be changed any time. As soon as we expose it as SPI or API it becomes much harder to change, so the bar is higher. Maybe isProcessingUserGesture is a sensible alternative.
Greg Bolsinga
Comment 5 2009-07-08 11:59:36 PDT
Should I change it in WebCore as well? Thanks.
Darin Adler
Comment 6 2009-07-08 12:02:19 PDT
(In reply to comment #5) > Should I change it in WebCore as well? Sure, I think so.
Greg Bolsinga
Comment 7 2009-07-08 13:18:57 PDT
Created attachment 32468 [details] updated to address Darin's comments
Greg Bolsinga
Comment 8 2009-07-08 14:28:26 PDT
-r45634 with an oddly super-long svn commit log.
Note You need to log in before you can comment on or make changes to this bug.