Bug 27076 – [WINCE] Move date related symbols to DateExtras.h

• Component: JavaScriptCore
• Status: RESOLVED INVALID

[Kwang Yul Seo]

Currently, date related symbols are imported from libce as described in https://bugs.webkit.org/show_bug.cgi?id=26558. DateConstructor, DatePrototype and DateMath requires 'localtime', 'strftime' and 'time'.


The better solution is to put these kinds of wordarounds into header files. We should put date related symbols into DateExtra.h, so it can be used for other platforms which also lack these symbols.


I copied the implementation of 'mktime', 'gmtime', 'localtime', 'strftime' and 'time' from libce and put them into DateExtras.cpp. I see no license problem with strftime because it is from OpenBSD, but other small functions are from public domain without license documentation. Please let me know if they are not acceptable. Anyway, I think it is better to get rid of libce dependency.

[Kwang Yul Seo]

Created attachment 32446 [details]
DateExtras

DateExtras

[Kwang Yul Seo]

Created attachment 32448 [details]
DateExtras

coding convention.

[Eric Seidel (no email)]

Comment on attachment 32448 [details]
DateExtras

Is JavaScriptCore/wtf/DateExtras.cpp all code you wrote?  Where can we validate the license if not?

There are lots of style errors.

Try using the new cpplint in WebKitTools/Scripts/

[Kwang Yul Seo]

Created attachment 32712 [details]
DateExtras

Okay. I removed the code from the public without license. Instead, I copied the implementation of WinCE time functions from wxWidgets-2.8.10 and modified them accordingly. wxWidgets is licensed under wxWindows Licence which is essentially LGPL, so I think there is no license problem here now.

http://www.wxwidgets.org/about/newlicen.htm


I also run the new lint tool and fixed some style errors. I am still not accustomed to the WebKit coding convention, there might be more errors.

cpplint.py DateExtras.*
Done processing DateExtras.cpp
Done processing DateExtras.h
Total errors found: 0

[George Staikos]

Comment on attachment 32712 [details]
DateExtras

This patch directly conflicts with the WinCE port that is in the process of being merged right now.  I don't think we need two conflicting ports - it's counterproductive.  If you would like to merge patches from our existing port you can find them online at http://code.staikos.net/.  Otherwise I'd ask you to be patient and allow that work to continue instead of creating conflicts.

[Kwang Yul Seo]

Okay. I will wait. Do you have a timeline when the merge is finished?

[George Staikos]

It's in progress but hard to predict.  There is a master bug: https://bugs.webkit.org/show_bug.cgi?id=23154

[Patrick R. Gansterer]

The dependencies on time, gmtime, localtime, mktime and strftime have been removed for WinCE in the meantime.