Bug 27055

Summary: Qualify include path with wtf
Product: WebKit Reporter: Norbert Leser <norbert.leser>
Component: JavaScriptCoreAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, hausmann, laszlo.gombos, yongjun.zhang
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: S60 Hardware   
OS: S60 3rd edition   
Bug Depends on:    
Bug Blocks: 27065    
Attachments:
Description Flags
Code patch for Interpreter.h
eric: review-
Second try. darin: review+

Norbert Leser
Reported 2009-07-07 19:03:20 PDT
Created attachment 32415 [details] Code patch for Interpreter.h On Symbian platforms we encounter include ambiguities of HashMap.h file, which is already present in default location. Since that header filename is very generic, it appears to be appropriate and saver to add a pathname qualifier "wtf/HashMap.h" to the include statement.
Attachments
Code patch for Interpreter.h (952 bytes, patch)
2009-07-07 19:03 PDT, Norbert Leser 		eric: review-
DetailsFormatted DiffDiff
Second try. (1.02 KB, patch)
2009-07-14 18:25 PDT, Laszlo Gombos 		darin: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Darin Adler
Comment 1 2009-07-07 21:59:39 PDT
Comment on attachment 32415 [details] Code patch for Interpreter.h It's OK to change the include here to the normal style, but the normal style is to include <wtf/HashMap.h> and include in a separate paragraph.
Eric Seidel (no email)
Comment 2 2009-07-13 00:45:54 PDT
Comment on attachment 32415 [details] Code patch for Interpreter.h r- per Darin's comment.
Laszlo Gombos
Comment 3 2009-07-14 18:25:31 PDT
Created attachment 32756 [details] Second try. Updated the patch based on Darin's feedback (filling in for Norbert.) Note that since this patch reverses a subset of r44418 (presumably a build fix for WIN_CAIRO), the proposed fix might break WIN_CAIRO port (I CCd Brent on the bug).
Brent Fulgham
Comment 4 2009-07-14 20:20:08 PDT
This change should be fine for WIN_CAIRO. I added the HashMap.h because it was needed to compile. Using the fully-qualified wtf/HashMap.h path should not be a problem.
Simon Hausmann
Comment 5 2009-07-15 08:14:25 PDT
Landed in r45909
Note You need to log in before you can comment on or make changes to this bug.