Bug 27053

Summary: Ambiguity in LabelScope initialization
Product: WebKit Reporter: Norbert Leser <norbert.leser>
Component: JavaScriptCoreAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: hausmann, laszlo.gombos, yongjun.zhang
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: S60 Emulator   
OS: S60 3rd edition   
Bug Depends on:    
Bug Blocks: 27065    
Attachments:
Description Flags
Code patch for BytecodeGenerator.cpp
ggaren: review+
Updated patch for bug# 27053 eric: review+

Norbert Leser
Reported 2009-07-07 18:52:25 PDT
Created attachment 32413 [details] Code patch for BytecodeGenerator.cpp Codewarrior compiler (WINSCW) latest b482 on Symbian cannot resolve type of "0" unambiguously. Set expression explicitly to PassRefPtr<Label>::PassRefPtr(). Rather than implementing conditional block for COMPILER(WINSCW) it appears to be save and appropriate to modify the main-line code accordingly.
Attachments
Code patch for BytecodeGenerator.cpp (1.42 KB, patch)
2009-07-07 18:52 PDT, Norbert Leser 		ggaren: review+
DetailsFormatted DiffDiff
Updated patch for bug# 27053 (1.40 KB, patch)
2009-07-07 19:39 PDT, Norbert Leser 		eric: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Geoffrey Garen
Comment 1 2009-07-07 19:09:16 PDT
Comment on attachment 32413 [details] Code patch for BytecodeGenerator.cpp r=me I think you can just write "PassRefPtr<Label>()" instead of "PassRefPtr<Label>::PassRefPtr()".
Norbert Leser
Comment 2 2009-07-07 19:39:23 PDT
Created attachment 32424 [details] Updated patch for bug# 27053 I just verified Geoffrey's suggestion about simplifying the statement, and he's right. The updated patch contains the respective modification.
Eric Seidel (no email)
Comment 3 2009-07-10 23:14:20 PDT
Comment on attachment 32424 [details] Updated patch for bug# 27053 OK. Your ChangeLog seems to have an extra return in it though.
Simon Hausmann
Comment 4 2009-07-13 01:20:40 PDT
Landed in r45791. The ChangeLog was made from the wrong directory, btw. I moved it up to JavaScriptCore/ChangeLog and fixed the path.
Note You need to log in before you can comment on or make changes to this bug.