Bug 27035

Summary:

[Chromium] Upstream DOMObjectsInclude.h

Product:

WebKit

Reporter:

Nate Chapin <japhet>

Component:

WebCore Misc.

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
patch	fishd: review+

Nate Chapin

Reported 2009-07-07 11:05:26 PDT

See summary.

Attachments
patch (7.16 KB, patch) 2009-07-07 11:09 PDT, Nate Chapin	fishd: review+	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Nate Chapin

Comment 1 2009-07-07 11:09:25 PDT

Created attachment 32387 [details] patch

Darin Fisher (:fishd, Google)

Comment 2 2009-07-07 13:18:50 PDT

Comment on attachment 32387 [details] patch > Index: WebCore/bindings/v8/DOMObjectsInclude.h > + * this software without specific prior written permission. > + * ^^^ looks like there is an extra space at the end of that line. > +#if ENABLE(DOM_STORAGE) > +#include "Storage.h" > +#include "StorageEvent.h" > +#endif ^^^ should that have a "// STORAGE" comment like the others? otherwise, R=me

Nate Chapin

Comment 3 2009-07-07 14:23:30 PDT

Landed at r45605. Thanks!

Note You need to log in before you can comment on or make changes to this bug.