Bug 270325
| Summary: | Add optimization in `handleStyleSpans()` to restrict 'for-loop' to iterate only over InsteredNodes | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Ahmad Saleem <ahmad.saleem792> |
| Component: | HTML Editing | Assignee: | Nobody <webkit-unassigned> |
| Status: | NEW | ||
| Severity: | Normal | CC: | rniwa, webkit-bug-importer, wenson_hsieh |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Ahmad Saleem
SSIA
Merge - https://chromium.googlesource.com/chromium/blink/+/9cb6b76486b616e567c0a3dc2dac6a800b353912
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Ryosuke Niwa
Seems okay to merge.
Radar WebKit Bug Importer
<rdar://problem/124240436>
Ahmad Saleem
It seems that it is triggering crashes in following test cases:
editing/inserting/inset-html-textarea-without-renderer.html
editing/pasteboard/5761530-2.html
fast/editing/replace-selection-command-crash.html
media/video-replaces-poster.html
PR attempt - https://github.com/WebKit/WebKit/pull/25325
It might be something in relation to now use 'RefPtr' or use it with with more changes beside just this.
@Ryosuke - any thoughts? Or you wanna explore it?