Bug 270321
| Summary: | Remove unnecessary copy when checking if a page is running an extension | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Ben Nham <nham> |
| Component: | WebKit Extensions | Assignee: | Ben Nham <nham> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | timothy, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Ben Nham
For every navigation decision, we check whether the associated page is running a web extension by calling `page.cocoaView().get().configuration._requiredWebExtensionBaseURL`. Since configuration is marked as a `copy` property, this causes an allocation and copy every time it's called. We should avoid the copy since it's not useful.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/123858678>
Ben Nham
Pull request: https://github.com/WebKit/WebKit/pull/25318
EWS
Committed 275538@main (35745daf8d35): <https://commits.webkit.org/275538@main>
Reviewed commits have been landed. Closing PR #25318 and removing active labels.