Bug 270118
| Summary: | Replies from GPUConnection::Connection::sendWithAsyncReply will always be called on the main thread | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Jean-Yves Avenard [:jya] <jean-yves.avenard> |
| Component: | WebKit2 | Assignee: | Jean-Yves Avenard [:jya] <jean-yves.avenard> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | cdumez, kkinnunen, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Bug Depends on: | |||
| Bug Blocks: | 270277, 270282 | ||
Jean-Yves Avenard [:jya]
When you send a message from the GPUConnection::connection()->sendWithAsyncReply (or sendWithPromisedReply), the reply will always be dispatched from the main thread.
It can make for some surprising behaviour when a WorkQueueMessageReceiver expect an answer on its defined work queue.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/123650202>
Jean-Yves Avenard [:jya]
A solution would be to have an override for `Connection::sendWithAsyncReply` that takes a SerialFunctionDispatcher on which the reply will be called on and pipe things internally to either dispatched the reply to Connection::dispatcher() or that defined SerialFunctionDispatcher.
Jean-Yves Avenard [:jya]
Pull request: https://github.com/WebKit/WebKit/pull/25092
Jean-Yves Avenard [:jya]
Pull request: https://github.com/WebKit/WebKit/pull/25166
EWS
Committed 275494@main (cae00d824a49): <https://commits.webkit.org/275494@main>
Reviewed commits have been landed. Closing PR #25166 and removing active labels.