Bug 269919

Summary: AX: Implement support for serving kAXLineForIndexParameterizedAttribute off the main-thread
Product: WebKit Reporter: Tyler Wilcock <tyler_w>
Component: AccessibilityAssignee: Tyler Wilcock <tyler_w>
Status: RESOLVED FIXED    
Severity: Normal CC: aboxhall, andresg_22, apinheiro, cfleizach, dmazzoni, ews-watchlist, jcraig, samuel_white, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Tyler Wilcock
Reported 2024-02-22 07:32:24 PST
...
Attachments
Patch (7.17 KB, patch)
2024-02-22 07:38 PST, Tyler Wilcock 		no flags
DetailsFormatted DiffDiff
Patch (7.31 KB, patch)
2024-02-26 00:18 PST, Tyler Wilcock 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2024-02-22 07:32:34 PST
<rdar://problem/123445635>
Tyler Wilcock
Comment 2 2024-02-22 07:38:20 PST
Created attachment 470014 [details] Patch
chris fleizach
Comment 3 2024-02-22 08:08:43 PST
Comment on attachment 470014 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=470014&action=review > Source/WebCore/accessibility/AXTextMarker.cpp:582 > + // We need to check index + 1 markers to behave correctly, so increment before iterating. is there a reason we need to increment here?
Tyler Wilcock
Comment 4 2024-02-26 00:18:16 PST
Created attachment 470047 [details] Patch
Tyler Wilcock
Comment 5 2024-02-26 00:22:45 PST
(In reply to chris fleizach from comment #3) > Comment on attachment 470014 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=470014&action=review > > > Source/WebCore/accessibility/AXTextMarker.cpp:582 > > + // We need to check index + 1 markers to behave correctly, so increment before iterating. > > is there a reason we need to increment here? It's needed to match the existing VisiblePosition-based implementation of this logic. After your comment, I investigated more deeply and tried a few things to avoid it, but wasn't successful. I can remove it, but it would cause us to fail a few parts of the newly added test. I just uploaded a new patch with a better comment explaining why we do this -- I figure we can re-work it later if it turns out to be wrong in some other different edge case.
EWS
Comment 6 2024-02-26 10:02:05 PST
Committed 275325@main (39028c1e4999): <https://commits.webkit.org/275325@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 470047 [details].
Note You need to log in before you can comment on or make changes to this bug.