Bug 269771

Summary: AX: refactor downcast in setLastPresentedTextPrediction
Product: WebKit Reporter: Joshua Hoffman <jhoffman23>
Component: AccessibilityAssignee: Joshua Hoffman <jhoffman23>
Status: RESOLVED FIXED    
Severity: Normal CC: aboxhall, andresg_22, apinheiro, cfleizach, dmazzoni, ews-watchlist, jcraig, samuel_white, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
none
Patch none

Joshua Hoffman
Reported 2024-02-19 21:07:26 PST
To avoid duplicate work during downcasting, we should separate where we perform the dynamic downcast and where we dereference the pointer.
Attachments
Patch (1.74 KB, patch)
2024-02-19 21:18 PST, Joshua Hoffman 		no flags
DetailsFormatted DiffDiff
Patch (1.74 KB, patch)
2024-02-19 21:36 PST, Joshua Hoffman 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2024-02-19 21:07:33 PST
<rdar://problem/123289610>
Joshua Hoffman
Comment 2 2024-02-19 21:18:43 PST
Created attachment 469986 [details] Patch
chris fleizach
Comment 3 2024-02-19 21:33:31 PST
Comment on attachment 469986 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=469986&action=review > Source/WebCore/accessibility/ios/AccessibilityObjectIOS.mm:144 > + auto nodeText = dynamicDowncast<Text>(previousCompositionNode); Auto*
Joshua Hoffman
Comment 4 2024-02-19 21:36:58 PST
Created attachment 469987 [details] Patch
EWS
Comment 5 2024-02-20 10:30:41 PST
Committed 275051@main (2f2435a780c4): <https://commits.webkit.org/275051@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 469987 [details].
Note You need to log in before you can comment on or make changes to this bug.