Bug 26976

Summary:

WebInspector: suggest global properties based on async evaluation.

Product:

WebKit

Reporter:

Pavel Feldman <pfeldman>

Component:

Web Inspector (Deprecated)

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

eric, timothy

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
Patch with the fix	timothy: review+
Patch with the fix	none
Patch with the fix	timothy: review+

Pavel Feldman

Reported 2009-07-05 04:05:36 PDT

At the moment, empty string was evaluated to the global object (or scope chain objects) synchronously. This is not in line with the rest of the code and needs to be fixed for the real serialized evaluation.

Attachments
Patch with the fix (4.36 KB, patch) 2009-07-05 04:09 PDT, Pavel Feldman	timothy: review+	Details Formatted Diff Diff
Patch with the fix (4.45 KB, application/octet-stream) 2009-07-05 05:43 PDT, Pavel Feldman	no flags	Details
Patch with the fix (4.45 KB, patch) 2009-07-05 05:46 PDT, Pavel Feldman	timothy: review+	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Pavel Feldman

Comment 1 2009-07-05 04:09:17 PDT

Created attachment 32271 [details] Patch with the fix

Pavel Feldman

Comment 2 2009-07-05 05:43:42 PDT

Created attachment 32272 [details] Patch with the fix

Pavel Feldman

Comment 3 2009-07-05 05:46:07 PDT

Created attachment 32273 [details] Patch with the fix

Eric Seidel (no email)

Comment 4 2009-07-06 13:48:49 PDT

Committing to http://svn.webkit.org/repository/webkit/trunk ... M WebCore/ChangeLog M WebCore/inspector/front-end/Console.js M WebCore/inspector/front-end/ScriptsPanel.js Committed r45562

Note You need to log in before you can comment on or make changes to this bug.