Bug 26958

Summary:

Change edit link to review link in request messages

Product:

WebKit

Reporter:

David Kilzer (:ddkilzer) <ddkilzer>

Component:

Tools / Tests

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

mitz

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Bug Depends on:

17457

Bug Blocks:

Attachments:

Description	Flags
Patch	mitz: review+

David Kilzer (:ddkilzer)

Reported 2009-07-03 18:46:22 PDT

Created attachment 32249 [details] Patch Mitz says that request messages should have a "review" link instead of and "edit" link. I'll add the bug number to the ChangeLog before committing.

Attachments
Patch (4.49 KB, patch) 2009-07-03 18:46 PDT, David Kilzer (:ddkilzer)	mitz: review+	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

David Kilzer (:ddkilzer)

Comment 1 2009-07-03 18:47:28 PDT

This is the only change after copying the file: $ diff -u BugsSite/template/en/default/request/email.txt.tmpl BugsSite/template/en/custom/request/email.txt.tmpl --- BugsSite/template/en/default/request/email.txt.tmpl 2009-07-02 21:30:23.000000000 -0700 +++ BugsSite/template/en/custom/request/email.txt.tmpl 2009-07-03 17:54:13.000000000 -0700 @@ -69,7 +69,7 @@ [% FILTER bullet = wrap(80) %] Attachment [% attidsummary %] [%- END %] -[%+ urlbase %]attachment.cgi?id=[% attachment.id %]&action=edit +[%+ urlbase %]attachment.cgi?id=[% attachment.id %]&action=review [%- END %] [%- FILTER bullet = wrap(80) %]

David Kilzer (:ddkilzer)

Comment 2 2009-07-03 20:28:08 PDT

$ git svn dcommit Committing to http://svn.webkit.org/repository/webkit/trunk ... M BugsSite/ChangeLog A BugsSite/template/en/custom/request/email.txt.tmpl Committed r45540 <http://trac.webkit.org/changeset/45540>

Note You need to log in before you can comment on or make changes to this bug.