Bug 269548
| Summary: | Adopt more smart pointers in AXObjectCache.cpp | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Chris Dumez <cdumez> |
| Component: | Accessibility | Assignee: | Diego Pino <dpino> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | andresg_22, dpino, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Chris Dumez
Adopt more smart pointers in AXObjectCache.cpp, as reported by the static analyzer.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/123066225>
Chris Dumez
Pull request: https://github.com/WebKit/WebKit/pull/24582
EWS
Committed 274894@main (4c899d7a2ab1): <https://commits.webkit.org/274894@main>
Reviewed commits have been landed. Closing PR #24582 and removing active labels.
Diego Pino
Debian Stable build bot is failing after this change:
https://build.webkit.org/#/builders/46/builds/37636
```
In file included from WebCore/DerivedSources/unified-sources/UnifiedSource-aba958d6-1.cpp:7:
../../../Source/WebCore/accessibility/AXTextMarker.cpp: In member function ‘WebCore::AXTextMarker::operator WebCore::CharacterOffset() const’:
../../../Source/WebCore/accessibility/AXTextMarker.cpp:163:28: error: ‘auto’ parameter not permitted in this context
163 | CharacterOffset result(RefPtr { m_data.node }.get(), m_data.characterStart, m_data.characterOffset);
| ^~~~~~
```
Diego Pino
Re-opening for pull request https://github.com/webkit/webkit/pull/24734
EWS
Committed 274968@main (fe3079fddbfb): <https://commits.webkit.org/274968@main>
Reviewed commits have been landed. Closing PR #24734 and removing active labels.