Bug 269475
| Summary: | 269988@main broke the ability to conditionally enable feature default values | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Mike Wyrzykowski <mwyrzykowski> |
| Component: | WebKit Misc. | Assignee: | Nobody <webkit-unassigned> |
| Status: | NEW | ||
| Severity: | Normal | CC: | emw, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Mike Wyrzykowski
In UnifiedWebPreferences.yaml there are quite a few features with defaults like so:
WebKit:
"PLATFORM(COCOA) || PLATFORM(GTK) || PLATFORM(WPE)": true
default: false
however the 'status' category is tightly coupled to the feature definition and there is no obvious way to have multiple feature categories or have a status that is not aligned with its default value.
This is the case when ENABLE_FEATURE_DEFAULT_VALIDATION is 1 which only applies to macOS 14 and later.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/123020563>
Elliott Williams
> however the 'status' category is tightly coupled to the feature definition and there is no obvious way to have multiple feature categories or have a status that is not aligned with its default value.
Yeah. I think it would be a good improvement to allow the status to be conditionally specified, i.e.
status:
PLATFORM(IOS_FAMILY): stable
default: preview
For now, the status should correspond with the feature's availability on macOS, since that is where feature status is user-visible.