Bug 269334
| Summary: | HTMLMediaElement::player() shouldn't return a RefPtr | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Chris Dumez <cdumez> |
| Component: | Media | Assignee: | Chris Dumez <cdumez> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Chris Dumez
HTMLMediaElement::player() shouldn't return a RefPtr as it causes unnecessary ref-counting churn for call sites that don't need it. Instead, follow the usual pattern:
1. Have HTMLMediaElement::player() return a raw pointer
2. Introduce a HTMLMediaElement::protectedPlayer() which returns a RefPtr for the call sites that need a RefPtr
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Chris Dumez
Pull request: https://github.com/WebKit/WebKit/pull/24384
EWS
Committed 274601@main (805716af7882): <https://commits.webkit.org/274601@main>
Reviewed commits have been landed. Closing PR #24384 and removing active labels.
Radar WebKit Bug Importer
<rdar://problem/122927456>