Bug 269331

Summary: Element::userAgentShadowRoot() shouldn't return a RefPtr
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: DOMAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   

Description Chris Dumez 2024-02-13 16:16:30 PST
Element::userAgentShadowRoot() shouldn't return a RefPtr. It causes unnecessary ref-counting churn for caller that don't need it. Have it return a raw pointer instead and add a `protectedUserAgentShadowRoot()` getter for the callers that actually want a RefPtr.
Comment 1 Chris Dumez 2024-02-13 16:21:08 PST
Pull request: https://github.com/WebKit/WebKit/pull/24382
Comment 2 EWS 2024-02-13 19:43:40 PST
Committed 274602@main (9951fe460428): <https://commits.webkit.org/274602@main>

Reviewed commits have been landed. Closing PR #24382 and removing active labels.
Comment 3 Radar WebKit Bug Importer 2024-02-13 19:44:24 PST
<rdar://problem/122927497>