Bug 269190
| Summary: | [Skia] Building with USE_SKIA=ON still uses Cairo for ImageDiff | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Adrian Perez <aperez> |
| Component: | Tools / Tests | Assignee: | Carlos Garcia Campos <cgarcia> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | cgarcia, fujii.hironori, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| See Also: | https://bugs.webkit.org/show_bug.cgi?id=269360 | ||
| Bug Depends on: | |||
| Bug Blocks: | 268972 | ||
Adrian Perez
Developer builds with USE_SKIA=ON still check for Cairo:
-- Found Cairo: /usr/lib/x86_64-linux-gnu/libcairo.so (found version "1.18.0")
This is still used by Tools/ImageDiff/ -- we should make it use
Skia as well.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Carlos Garcia Campos
Do we even use ImageDiff nowadays?
Fujii Hironori
Yes, ref tests are using ImageDiff.
Carlos Garcia Campos
Pull request: https://github.com/WebKit/WebKit/pull/24333
EWS
Committed 274544@main (0e6f0245ab8d): <https://commits.webkit.org/274544@main>
Reviewed commits have been landed. Closing PR #24333 and removing active labels.
Radar WebKit Bug Importer
<rdar://problem/122868769>