Bug 269165
| Summary: | [Digital Identity]: navigator.identity should be implemented by a separate IdentityCredentialManager | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Marcos Caceres <marcosc> |
| Component: | WebCore Misc. | Assignee: | Marcos Caceres <marcosc> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | Other | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Bug Depends on: | 268726 | ||
| Bug Blocks: | 268516 | ||
Marcos Caceres
Once bug 268516 is in place, we need to implement an IdentityCredentialManager class that inherits from CredentialManager.
My idea is to make the methods on CredentialManager all virtual, so to allow IdentityCredentialManager to override them.
At the same time, we want to have shared error checking behavior in both IdentityCredentialManager and CredentialManager, so need to make sure that we split those checks out.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Marcos Caceres
I mean, once 268726 is in place instead.
Radar WebKit Bug Importer
<rdar://problem/123184696>
Marcos Caceres
Pull request: https://github.com/WebKit/WebKit/pull/25338
EWS
Committed 275939@main (2dbfef33bb52): <https://commits.webkit.org/275939@main>
Reviewed commits have been landed. Closing PR #25338 and removing active labels.