Bug 269024
| Summary: | [Wasm-GC] Fix subtype hashing | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Asumu Takikawa <asumu> |
| Component: | WebAssembly | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | bashorov, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Bug Depends on: | |||
| Bug Blocks: | 247394 | ||
Asumu Takikawa
The following test case, that passes the reference interpreter, currently fails:
```
instantiate(`
(module
(rec
(type (sub (struct)))
(type (sub final 0 (struct (field i32 (ref 0)))))
(type (sub 0 (struct (field i32 (ref 0)))))
(type (sub 2 (struct (field i32 (ref 0))))) ;; valid subtype
)
)
`);
```
(goes in wasm/gc/sub.js)
The bug appears to be that hashing of sub types is slightly wrong and doesn't account for the final flag.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Asumu Takikawa
Pull request: https://github.com/WebKit/WebKit/pull/24106
EWS
Committed 274555@main (e588a9dece40): <https://commits.webkit.org/274555@main>
Reviewed commits have been landed. Closing PR #24106 and removing active labels.
Radar WebKit Bug Importer
<rdar://problem/122890814>