Bug 269001
| Summary: | Adopt more smart pointers for SVGDocumentExtensions | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Chris Dumez <cdumez> |
| Component: | SVG | Assignee: | Chris Dumez <cdumez> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | sabouhallawa, webkit-bug-importer, zimmermann |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Chris Dumez
Adopt more smart pointers for SVGDocumentExtensions:
1. Rename `Document::svgExtensions()` to `Document::svgExtensionsIfExists()` and `Document::accessSVGExtensions()` to `Document::svgExtensions()` for consistency with our usual naming conventions.
2. Introduce `Document::checkedSVGExtensions()` which returns a `CheckedRef<>` and adopt where appropriate.
3. Update call site to make sure the `Document` is protected during the scope of the SVGDocumentExtensions variable, since it owns it.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Chris Dumez
Pull request: https://github.com/WebKit/WebKit/pull/24085
EWS
Committed 274316@main (dccc78696b92): <https://commits.webkit.org/274316@main>
Reviewed commits have been landed. Closing PR #24085 and removing active labels.
Radar WebKit Bug Importer
<rdar://problem/122584885>