Bug 268962
| Summary: | [Perf Dashboard] AsyncTaskWorker is buggy | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Ryosuke Niwa <rniwa> |
| Component: | Tools / Tests | Assignee: | Yusuke Suzuki <ysuzuki> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | mark.lam, webkit-bug-importer, yijia_huang, ysuzuki |
| Priority: | P2 | Keywords: | InRadar |
| Version: | Safari Technology Preview | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Ryosuke Niwa
AsyncTaskWorker has two bugs:
1. waitForAvailableWorker is pushing callback while it finds an available worker. This does not make sense since we will invoke this callback twice.
2. This setTimeout code is assuming that, after the wait, there is still a callback in the queue. But this is not guaranteed since worker will continuously consume tasks from queue. So if the other workers are finishing their task, and consume next one, and if it gets exhausted when executing this setTimeout's task, then we hit an error
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Yusuke Suzuki
<rdar://problem/121879117>
Yusuke Suzuki
Pull request: https://github.com/WebKit/WebKit/pull/24053
EWS
Committed 274265@main (dde5760b8dbf): <https://commits.webkit.org/274265@main>
Reviewed commits have been landed. Closing PR #24053 and removing active labels.