Bug 26891

Summary: Remove unused code in SVGTransformList and SVGTransformDistance
Product: WebKit Reporter: David Levin <levin>
Component: SVGAssignee: David Levin <levin>
Status: RESOLVED FIXED    
Severity: Normal CC: eric
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
patch eric: review+

David Levin
Reported 2009-07-01 11:34:40 PDT
This code had the potential to use an uninitialized m_cx, m_cy. Since it is unused, I'm simply removing it.
Attachments
patch (4.61 KB, patch)
2009-07-01 11:38 PDT, David Levin 		eric: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
David Levin
Comment 1 2009-07-01 11:38:30 PDT
Created attachment 32131 [details] patch
Eric Seidel (no email)
Comment 2 2009-07-01 13:36:12 PDT
Comment on attachment 32131 [details] patch Why not fix the default constructor? I support removing the dead code though. Wow, this code is old. This was from yet-another attempt at animation by yours truly... forever ago. I think you shoudl fix the default constructor to zero everything instead of changing the callsites.
David Levin
Comment 3 2009-07-01 14:07:39 PDT
Committed as http://trac.webkit.org/changeset/45448 I did a slight modification to change the default constructor as Eric suggested.
Note You need to log in before you can comment on or make changes to this bug.