Bug 268885

Summary: [FFC] Flex Formatting Context should follow IFC's integration codepath design
Product: WebKit Reporter: zalan <zalan>
Component: Layout and RenderingAssignee: zalan <zalan>
Status: RESOLVED FIXED    
Severity: Normal CC: annulen, bfulgham, ews-watchlist, gyuyoung.kim, koivisto, olivier.blin, ryuan.choi, sergio, simon.fraser, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
ews-feeder: commit-queue-
Patch
none
[fast-cq]Patch
none
[fast-cq]Patch none

zalan
Reported 2024-02-06 19:12:40 PST
ssia
Attachments
Patch (51.12 KB, patch)
2024-02-06 19:21 PST, zalan 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Patch (51.79 KB, patch)
2024-02-06 19:47 PST, zalan 		no flags
DetailsFormatted DiffDiff
[fast-cq]Patch (51.78 KB, patch)
2024-02-07 07:35 PST, zalan 		no flags
DetailsFormatted DiffDiff
[fast-cq]Patch (47.73 KB, patch)
2024-02-08 07:09 PST, zalan 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
zalan
Comment 1 2024-02-06 19:21:10 PST
Created attachment 469756 [details] Patch
zalan
Comment 2 2024-02-06 19:47:52 PST
Created attachment 469757 [details] Patch
zalan
Comment 3 2024-02-07 07:35:02 PST
Created attachment 469759 [details] [fast-cq]Patch
EWS
Comment 4 2024-02-07 15:44:49 PST
Committed 274252@main (56ef8327a9a9): <https://commits.webkit.org/274252@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 469759 [details].
Radar WebKit Bug Importer
Comment 5 2024-02-07 15:46:15 PST
<rdar://problem/122502444>
Jonathan Bedard
Comment 6 2024-02-07 21:05:57 PST
Broke the watchOS build, tracking revert in https://bugs.webkit.org/show_bug.cgi?id=268964
zalan
Comment 7 2024-02-08 07:09:17 PST
Created attachment 469771 [details] [fast-cq]Patch
EWS
Comment 8 2024-02-08 10:47:43 PST
Committed 274300@main (4bd4d4f8b539): <https://commits.webkit.org/274300@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 469771 [details].
Olivier Blin
Comment 9 2024-02-12 04:59:30 PST
Comment on attachment 469771 [details] [fast-cq]Patch View in context: https://bugs.webkit.org/attachment.cgi?id=469771&action=review > Source/WebCore/layout/formattingContexts/flex/FlexFormattingUtils.cppSource/WebCore/layout/formattingContexts/flex/FlexFormattingState.cpp:37 > + : m_flexFormattingContext(flexFormattingContext) Will the m_flexFormattingContext variable be used later? It is unused right now. It triggers build errors on Clang linux debug builds, with -Werror,-Wunused-private-field
zalan
Comment 10 2024-02-12 08:46:34 PST
(In reply to Olivier Blin from comment #9) > Comment on attachment 469771 [details] > [fast-cq]Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=469771&action=review > > > Source/WebCore/layout/formattingContexts/flex/FlexFormattingUtils.cppSource/WebCore/layout/formattingContexts/flex/FlexFormattingState.cpp:37 > > + : m_flexFormattingContext(flexFormattingContext) > > Will the m_flexFormattingContext variable be used later? > It is unused right now. > > It triggers build errors on Clang linux debug builds, with > -Werror,-Wunused-private-field Yeah, it is going to be used soon but also if it blocks you in any way, feel free to remove it (or let me know if you want me to remove it). Thanks!
Olivier Blin
Comment 11 2024-02-12 10:45:47 PST
(In reply to zalan from comment #10) > (In reply to Olivier Blin from comment #9) > > Will the m_flexFormattingContext variable be used later? > > It is unused right now. > > > > It triggers build errors on Clang linux debug builds, with > > -Werror,-Wunused-private-field > Yeah, it is going to be used soon but also if it blocks you in any way, feel > free to remove it (or let me know if you want me to remove it). Thanks! No, that's ok if it is going to be used later. Thanks for the heads-up!
Note You need to log in before you can comment on or make changes to this bug.