Bug 268796
| Summary: | [MSE] Remove HTMLMediaElement access from MediaSource | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Jean-Yves Avenard [:jya] <jean-yves.avenard> |
| Component: | Media | Assignee: | Jean-Yves Avenard [:jya] <jean-yves.avenard> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Bug Depends on: | 268911 | ||
| Bug Blocks: | 264134 | ||
Jean-Yves Avenard [:jya]
subtask of bug 264134
Currently the MediaSource::monitorSourceBuffer requires the mediaElement's currentTime.
But to do so, it directly access the HTMLMediaElement::currentMediaTime [1]
As the MediaSource may not be running in the same thread in the future, it may not be safe for the MediaSource to directly access the MediaElement.
An alternative would be to access the MediaPlayer instead, which has a more up to date value of the current time.
[1] https://searchfox.org/wubkat/rev/5266b069f715d2051da7f1fc8def26d5dcd5e03c/Source/WebCore/Modules/mediasource/MediaSource.cpp#182-187
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/122359957>
Jean-Yves Avenard [:jya]
Pull request: https://github.com/WebKit/WebKit/pull/24142
EWS
Committed 274442@main (b0908a7024e1): <https://commits.webkit.org/274442@main>
Reviewed commits have been landed. Closing PR #24142 and removing active labels.