Bug 268774
| Summary: | Re-enable tests that check clientDataJSON for TestRunner | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | pascoe <pascoe> |
| Component: | WebKit Misc. | Assignee: | pascoe <pascoe> |
| Status: | NEW | ||
| Severity: | Normal | CC: | bfulgham, pascoe, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
pascoe@apple.com
These don't work right now because we don't mock calls to AuthenticationServicesAgent. We should do that to improve our web authn-related layout tests.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
pascoe@apple.com
In the short term I have set clientDataJSON manually when we are running in tests, which will allow us to reenable
- http/wpt/webauthn/idl.https.html
- http/wpt/webauthn/public-key-credential-create-success-ccid.https.html
- http/wpt/webauthn/public-key-credential-create-success-local.https.html
- http/wpt/webauthn/public-key-credential-create-success-u2f.https.html
- http/wpt/webauthn/public-key-credential-get-success-ccid.https.html
- http/wpt/webauthn/public-key-credential-get-success-hid.https.html
In the longer term I'm going to sit down and write a mock implementation of our AS... APIs to make the tests run in a configuration closer to reality.
Radar WebKit Bug Importer
<rdar://problem/122350233>
pascoe@apple.com
Pull request: https://github.com/WebKit/WebKit/pull/23950
EWS
Test gardening commit 274169@main (a33387dca368): <https://commits.webkit.org/274169@main>
Reviewed commits have been landed. Closing PR #23950 and removing active labels.