Bug 268645
| Summary: | WebExtensionContext::handleContentRuleListNotificationForTab activeTab permission check is wrong | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Timothy Hatcher <timothy> |
| Component: | WebKit Extensions | Assignee: | Brian Weinstein <bweinstein> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | timothy, tzyy9873, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Local Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Timothy Hatcher
We should do `hasPermission(url, &tab)` instead of `hasPermission(_WKWebExtensionPermissionActiveTab)`, which will properly check for all host permission cases, including `activeTab` temp host permissions.
I'm not even sure the `hasPermission(_WKWebExtensionPermissionDeclarativeNetRequest)` check is needed, since we already check `_WKWebExtensionPermissionDeclarativeNetRequestFeedback`.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/122197589>
Radar WebKit Bug Importer
<rdar://problem/122197797>
Timothy Hatcher
<rdar://problem/122197589>
Brian Weinstein
Pull request: https://github.com/WebKit/WebKit/pull/23788
EWS
Committed 274030@main (63b67f18d2d2): <https://commits.webkit.org/274030@main>
Reviewed commits have been landed. Closing PR #23788 and removing active labels.