Bug 26859

Summary:

StorageNamespace.cpp build issue

Product:

WebKit

Reporter:

Maxime Simon <simon.maxime>

Component:

WebCore Misc.

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
Patch for this bug	eric: review+

Maxime Simon

Reported 2009-06-30 13:56:16 PDT

In WebCore/storage/StorageNamespace.cpp, namespace WebCore is closed after the #endif (which starts before the namespace). So if #if ENABLE(DOM_STORAGE) is true there is no problem, but if not it causes the build to fail.

Attachments
Patch for this bug (1.58 KB, patch) 2009-06-30 14:07 PDT, Maxime Simon	eric: review+	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Maxime Simon

Comment 1 2009-06-30 14:07:15 PDT

Created attachment 32093 [details] Patch for this bug

Eric Seidel (no email)

Comment 2 2009-06-30 14:42:46 PDT

Comment on attachment 32093 [details] Patch for this bug LGTM.

Jan Alonzo

Comment 3 2009-06-30 19:16:26 PDT

(In reply to comment #2) > (From update of attachment 32093 [details] [review]) > LGTM. > Landed in r45413.

Note You need to log in before you can comment on or make changes to this bug.