Bug 268545
| Summary: | Remove unused function `PaginationUnit` and related code from ColumnInfo.h | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Ahmad Saleem <ahmad.saleem792> |
| Component: | Layout and Rendering | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | bfulgham, simon.fraser, webkit-bug-importer, zalan |
| Priority: | P2 | Keywords: | InRadar |
| Version: | Safari Technology Preview | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Ahmad Saleem
Hi Team,
While trying to remove -webkit-column-* legacy stuff, I noticed that this function is pretty much dead code.
> Source/WebCore/rendering/ColumnInfo.h:
, m_paginationUnit(Column)
enum PaginationUnit { Column, Page };
PaginationUnit paginationUnit() const { return m_paginationUnit; }
void setPaginationUnit(PaginationUnit paginationUnit) { m_paginationUnit = paginationUnit; }
PaginationUnit m_paginationUnit;
__
Just wanted to raise so we can get rid of it.
Thanks!
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
EWS
Committed 273925@main (289dfe401a12): <https://commits.webkit.org/273925@main>
Reviewed commits have been landed. Closing PR #23664 and removing active labels.
Radar WebKit Bug Importer
<rdar://problem/122116621>