WebKit Bugzilla
New
Browse
Search+
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
268545
Remove unused function `PaginationUnit` and related code from ColumnInfo.h
https://bugs.webkit.org/show_bug.cgi?id=268545
Summary
Remove unused function `PaginationUnit` and related code from ColumnInfo.h
Ahmad Saleem
Reported
2024-02-01 04:52:30 PST
Hi Team, While trying to remove -webkit-column-* legacy stuff, I noticed that this function is pretty much dead code.
> Source/WebCore/rendering/ColumnInfo.h:
, m_paginationUnit(Column) enum PaginationUnit { Column, Page }; PaginationUnit paginationUnit() const { return m_paginationUnit; } void setPaginationUnit(PaginationUnit paginationUnit) { m_paginationUnit = paginationUnit; } PaginationUnit m_paginationUnit; __ Just wanted to raise so we can get rid of it. Thanks!
Attachments
Add attachment
proposed patch, testcase, etc.
EWS
Comment 1
2024-02-01 10:57:11 PST
Committed
273925@main
(289dfe401a12): <
https://commits.webkit.org/273925@main
> Reviewed commits have been landed. Closing PR #23664 and removing active labels.
Radar WebKit Bug Importer
Comment 2
2024-02-01 10:58:15 PST
<
rdar://problem/122116621
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug