Bug 268379
| Summary: | TestShard can't actually pickle reference_files | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Sam Sneddon [:gsnedders] <gsnedders> |
| Component: | Tools / Tests | Assignee: | Sam Sneddon [:gsnedders] <gsnedders> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | jbedard, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Bug Depends on: | |||
| Bug Blocks: | 220421 | ||
Sam Sneddon [:gsnedders]
self = TestShard(name='failures/expected', test_inputs=[TestInput(test=Test(test_path='failures/expected/empty.html', expecte...=None, should_dump_jsconsolelog_in_stderr=None, reference_files=None, should_run_pixel_test=None)], needs_servers=None'
string = ('!=', '/test.checkout/LayoutTests/failures/expected/mismatch-expected-mismatch.html')
def shorten(self, string):
if not string:
return string
> return string.replace('{}/'.format(self.name), '{}')
E AttributeError: 'tuple' object has no attribute 'replace'
layout_tests/controllers/layout_test_runner.py:511: AttributeError
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Sam Sneddon [:gsnedders]
Pull request: https://github.com/WebKit/WebKit/pull/23512
EWS
Committed 273789@main (5d4d9c7ef39a): <https://commits.webkit.org/273789@main>
Reviewed commits have been landed. Closing PR #23512 and removing active labels.
Radar WebKit Bug Importer
<rdar://problem/121959570>