Bug 268060
| Summary: | `check-webkit-style --git-index` fails with error | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Simon Fraser (smfr) <simon.fraser> |
| Component: | Tools / Tests | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED DUPLICATE | ||
| Severity: | Normal | CC: | bfan2, jbedard, simon.fraser, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Simon Fraser (smfr)
OpenSource % ./Tools/Scripts/check-webkit-style --git-index
Traceback (most recent call last):
File "/Volumes/Data/Development/system/webkit/OpenSource/./Tools/Scripts/check-webkit-style", line 46, in <module>
sys.exit(CheckWebKitStyle().main())
File "/Volumes/Data/Development/system/webkit/OpenSource/Tools/Scripts/webkitpy/style/main.py", line 157, in main
patch = host.scm().create_patch(options.git_commit, changed_files=changed_files, git_index=options.git_index, find_branch=True)
File "/Volumes/Data/Development/system/webkit/OpenSource/Tools/Scripts/webkitpy/common/checkout/scm/git.py", line 376, in create_patch
assert command[1] == 'diff'
AssertionError
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/122068513>
Jonathan Bedard
I can't reproduce this. Is there any more information about the state of your checkout when encountering this error? Looking at the code, I suspect this has something to do with generating a patch with a commit message instead of just a diff, so it's probably related to to being on a PR branch vs main and then having a commit vs just changed files.
Jonathan Bedard
User says this works for them now, closing this bug.
Sam Sneddon [:gsnedders]
This will've been fixed by bug 265030, 273780@main.
*** This bug has been marked as a duplicate of bug 265030 ***