Bug 267707
| Summary: | Make more service worker classes ref-counted | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Chris Dumez <cdumez> |
| Component: | Service Workers | Assignee: | Chris Dumez <cdumez> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | fujii.hironori, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Bug Depends on: | |||
| Bug Blocks: | 267748 | ||
Chris Dumez
I recently did smart adoption of smart pointers in service worker code. In doing so I had to use CheckedPtr a lot because many of the classes were not ref-counted and I had no way to "protect" an object before calling a member function on it. It was then pointed out to me that we could make those classes ref-counted instead. I gave it a try and I think the code looks a lot safer. It is also a lot less likely to introduce new crashes (since it decreases the use of CheckedPtr).
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Chris Dumez
Pull request: https://github.com/WebKit/WebKit/pull/22919
EWS
Committed 273187@main (24bcf01c94b3): <https://commits.webkit.org/273187@main>
Reviewed commits have been landed. Closing PR #22919 and removing active labels.
Radar WebKit Bug Importer
<rdar://problem/121207803>