Summary: | First `make release` fails after deleting `WebKitBuild` directory | ||
---|---|---|---|
Product: | WebKit | Reporter: | Elliott Williams <emw> |
Component: | Tools / Tests | Assignee: | Elliott Williams <emw> |
Status: | RESOLVED FIXED | ||
Severity: | Normal | CC: | webkit-bug-importer |
Priority: | P2 | Keywords: | InRadar |
Version: | WebKit Nightly Build | ||
Hardware: | Unspecified | ||
OS: | Unspecified | ||
Bug Depends on: | 266493 | ||
Bug Blocks: |
Description
Elliott Williams
2024-01-17 21:43:52 PST
https://commits.webkit.org/273153@main changed a Makefile line from: XCODE_OPTIONS = `perl -I$(SCRIPTS_PATH) -Mwebkitdirs -e 'print XcodeOptionString()' -- $(BUILD_WEBKIT_OPTIONS)` $(ARGS) to: XCODE_OPTIONS = $(shell perl -I$(SCRIPTS_PATH) -Mwebkitdirs -e 'print XcodeOptionString()' -- $(BUILD_WEBKIT_BASE) I thought that the $(shell ) directive was lazy enough that it wouldn't get expanded until we had already done all needed setup. But it's getting expanded before the call to set-webkit-configuration, which may change the active workspace. Pull request: https://github.com/WebKit/WebKit/pull/22895 Committed 273165@main (f31c5c1ab031): <https://commits.webkit.org/273165@main> Reviewed commits have been landed. Closing PR #22895 and removing active labels. |