Bug 267617
| Summary: | fast/css/ios/update-user-interface-level.html fails if nothing triggers a style update on the root | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Simon Fraser (smfr) <simon.fraser> |
| Component: | Tools / Tests | Assignee: | Nobody <webkit-unassigned> |
| Status: | NEW | ||
| Severity: | Normal | CC: | webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Simon Fraser (smfr)
This PR [https://github.com/WebKit/WebKit/pull/22531] causes fast/css/ios/update-user-interface-level.html to fail.
This test updates dark mode and "elevated user interface level" and checks to see if the base background color changed. baseBackgroundColor is updated in `LocalFrameView::updateBackgroundRecursively()` via:
auto baseBackgroundColor = backgroundColor.value_or(RenderTheme::singleton().systemColor(cssValueControlBackground, view->styleColorOptions()));
and in this case we're always calling `RenderTheme::singleton().systemColor(cssValueControlBackground()`.
The problem is that the result of RenderTheme::singleton().systemColor() can change without a `styleDidChange` being triggered.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/121490021>