Bug 267417
| Summary: | [MSE][GStreamer] Dimension SourceBuffer size limit for all possible track types before init segment received | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Enrique Ocaña <eocanha> |
| Component: | Media | Assignee: | Enrique Ocaña <eocanha> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Enrique Ocaña
SourceBuffer has separate max size limits for video, audio and text, but it has to parse the init segment first to know if there are any video, audio or text tracks. At the very first appendBuffer() there are not tracks parsed yet, so platformMaximumBufferSize() returns 0 (as no tracks are there), and the limit is taken from MediaElementSession as audio limit 15MB as no video track is present.
A potential buffer overflow at the very first appendBuffer() before tracks are parsed from init segment should be ignored.
See: https://github.com/WebPlatformForEmbedded/WPEWebKit/pull/1261
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Enrique Ocaña
Pull request: https://github.com/WebKit/WebKit/pull/22671
EWS
Committed 273039@main (71e98e404115): <https://commits.webkit.org/273039@main>
Reviewed commits have been landed. Closing PR #22671 and removing active labels.
Radar WebKit Bug Importer
<rdar://problem/121004491>