Bug 26719

Summary: A few fixes for bugzilla-tool
Product: WebKit Reporter: Tor Arne Vestbø <vestbo>
Component: Tools / TestsAssignee: Eric Seidel (no email) <eric>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Mac   
OS: OS X 10.5   
Attachments:
Description Flags
bugzilla-tool: use unicode instead of str when fetching the patch name
levin: review+
bugzilla-tool: Add Simon Hausmann as reviewer none

Tor Arne Vestbø
Reported 2009-06-25 04:35:51 PDT
A few fixes for bugzilla-tool
Attachments
bugzilla-tool: use unicode instead of str when fetching the patch name (1.42 KB, patch)
2009-06-25 04:40 PDT, Tor Arne Vestbø 		levin: review+
DetailsFormatted DiffDiff
bugzilla-tool: Add Simon Hausmann as reviewer (990 bytes, patch)
2009-06-25 04:40 PDT, Tor Arne Vestbø 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Tor Arne Vestbø
Comment 1 2009-06-25 04:40:12 PDT
Created attachment 31852 [details] bugzilla-tool: use unicode instead of str when fetching the patch name --- 2 files changed, 9 insertions(+), 1 deletions(-)
Tor Arne Vestbø
Comment 2 2009-06-25 04:40:16 PDT
Created attachment 31853 [details] bugzilla-tool: Add Simon Hausmann as reviewer --- 2 files changed, 9 insertions(+), 0 deletions(-)
Jan Alonzo
Comment 3 2009-06-25 04:50:49 PDT
Comment on attachment 31853 [details] bugzilla-tool: Add Simon Hausmann as reviewer > +++ b/WebKitTools/Scripts/modules/bugzilla.py > @@ -89,6 +89,7 @@ class Bugzilla: > "eric" : "Eric Seidel", > "fishd" : "Darin Fisher", > "gns" : "Gustavo Noronha", > + "hausmann" : "Simon Hausmann", r=me.
David Levin
Comment 4 2009-06-25 09:00:31 PDT
Comment on attachment 31852 [details] bugzilla-tool: use unicode instead of str when fetching the patch name Please add the link to the bug in the changelog (even though in this case it doesn't really add anything).
Eric Seidel (no email)
Comment 5 2009-06-25 10:10:14 PDT
Yup, these look good.
Eric Seidel (no email)
Comment 6 2009-06-25 13:37:43 PDT
I'm not sure why this is assigned to me? Unless I'm supposed to land it?
Eric Seidel (no email)
Comment 7 2009-06-25 14:10:58 PDT
I need the reviewer fix, so will land.
Eric Seidel (no email)
Comment 8 2009-06-25 14:12:55 PDT
svn-apply doesn't seem to fix the ChangeLog correctly when applying this. Odd.
Eric Seidel (no email)
Comment 9 2009-06-25 14:18:19 PDT
Comment on attachment 31853 [details] bugzilla-tool: Add Simon Hausmann as reviewer This was already commited: http://trac.webkit.org/changeset/45174
Eric Seidel (no email)
Comment 10 2009-06-25 14:26:31 PDT
Committing to http://svn.webkit.org/repository/webkit/trunk ... M WebKitTools/ChangeLog M WebKitTools/Scripts/modules/bugzilla.py Committed r45192 http://trac.webkit.org/changeset/45192
Note You need to log in before you can comment on or make changes to this bug.