Bug 267091
| Summary: | Factor PDF JS evaluation out of PDFPlugin | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Tim Horton <thorton> |
| Component: | Assignee: | Tim Horton <thorton> | |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | jbedard, thorton |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Tim Horton
Factor PDF JS evaluation out of PDFPlugin
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Tim Horton
Pull request: https://github.com/WebKit/WebKit/pull/22391
Tim Horton
rdar://118550726
EWS
Committed 272706@main (0474d6003056): <https://commits.webkit.org/272706@main>
Reviewed commits have been landed. Closing PR #22391 and removing active labels.
Jonathan Bedard
Looks like this change caused a regression in TestWebKitAPI.PDF.PrintSize:
https://results.webkit.org/?suite=api-tests&test=TestWebKitAPI.PDF.PrintSize
Tim Horton
It sure does! Looking.
Tim Horton
(In reply to Tim Horton from comment #5)
> It sure does! Looking.
Weird, passes here.
Tim Horton
(In reply to Tim Horton from comment #6)
> (In reply to Tim Horton from comment #5)
> > It sure does! Looking.
>
> Weird, passes here.
The bots are also bizarrely inconsistent, I can't puzzle out the rhyme or reason
Tim Horton
ok, I have a fix. will post a patch tomorrow. There's something weird about one of the bots where it claims to be AS but is acting like Intel.
Tim Horton
(In reply to Tim Horton from comment #8)
> ok, I have a fix. will post a patch tomorrow.
-> https://bugs.webkit.org/show_bug.cgi?id=267403