Bug 26696

Summary: Member functions in DataGridColumnList should return pointers instead of PassRefPtr
Product: WebKit Reporter: David Levin <levin>
Component: FormsAssignee: David Levin <levin>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Mac   
OS: OS X 10.5   
Attachments:
Description Flags
Proposed fix. hyatt: review+

David Levin
Reported 2009-06-24 15:26:05 PDT
The PassRefPtr is usually returned to indicate that the ref count is being passed and that isn't the case here. The class still maintains a ref count on these items. (Besides just that general idea, I'm doing this because it helps me get our autogenerated code for v8 bindings building.)
Attachments
Proposed fix. (3.80 KB, patch)
2009-06-24 15:35 PDT, David Levin 		hyatt: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
David Levin
Comment 1 2009-06-24 15:35:54 PDT
Created attachment 31814 [details] Proposed fix.
Dave Hyatt
Comment 2 2009-06-24 15:38:06 PDT
Comment on attachment 31814 [details] Proposed fix. r=me
David Levin
Comment 3 2009-06-24 15:48:31 PDT
Committed as http://trac.webkit.org/changeset/45111
Note You need to log in before you can comment on or make changes to this bug.