Bug 266897
| Summary: | Exposing navigator.language to web workers | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Ahmad Saleem <ahmad.saleem792> |
| Component: | DOM | Assignee: | Nobody <webkit-unassigned> |
| Status: | NEW | ||
| Severity: | Normal | CC: | ap, cdumez, heycam, karlcow, webkit-bug-importer |
| Priority: | P2 | Keywords: | BrowserCompat, InRadar, WPTImpact |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Ahmad Saleem
Hi Team,
While investigating WPT failures, I noticed that we fail two tests here:
WPT Test Case: https://wpt.fyi/results/html/dom/idlharness.worker.html?label=master&label=experimental&aligned=&q=safari%3Afail
> WorkerGlobalScope interface: attribute onlanguagechange
> WorkerGlobalScope interface: self must inherit property "onlanguagechange" with the proper type
WebKit / Safari is only browser currently failing these (so I will add 'BrowserCompat' tag - in addition to 'WPTImpact').
Blink Commit (for reference) - https://chromium.googlesource.com/chromium/src.git/+/6c688717fa4d50920ebcb0ab80e95023ff562656
FIXME in WebKit Source: https://searchfox.org/wubkat/rev/2cb2f84b68df8a519e252d535de43e7d19567883/Source/WebCore/workers/WorkerGlobalScope.idl#39
I didn't manage to find similar bug so I thought to raise for better tracking.
Thanks!
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Ahmad Saleem
NOTE - just uncommenting in IDL file (FIXME) leads to test progression. So we might have already necessary implementation. Although, will wait for more context or input from others.
Alexey Proskuryakov
Language.cpp has some locking added for OffscreenCanvas thread safety, so Navigator.language may indeed be trivial to enable in workers at this point. Careful verification would still be needed, of course.
However onlanguagechange clearly doesn't have an implementation, so uncommenting the line in IDL won't make it work.
Radar WebKit Bug Importer
<rdar://problem/120378717>