Bug 26685

Summary:

[Skia] Skia folded SkPorterDuff into SkXfermode

Product:

WebKit

Reporter:

Nico Weber <thakis>

Component:

WebKit Misc.

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

brettw, dglazkov

Priority:

Version:

528+ (Nightly build)

Hardware:

Mac

OS:

OS X 10.5

Attachments:

Description	Flags
Use new skia api	none
Fill in bug, reviewer, and email fields	none

Nico Weber

Reported 2009-06-24 10:32:47 PDT

Skia did an backwards-incompatible api change (r232, 235, 236, 239 at http://code.google.com/p/skia/source/list ). Use the new api.

Attachments
Use new skia api (10.95 KB, patch) 2009-06-24 10:36 PDT, Nico Weber	no flags	Details Formatted Diff Diff
Fill in bug, reviewer, and email fields (10.99 KB, patch) 2009-06-24 14:01 PDT, Nico Weber	no flags	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Nico Weber

Comment 1 2009-06-24 10:36:22 PDT

Created attachment 31790 [details] Use new skia api

Eric Seidel (no email)

Comment 2 2009-06-24 13:48:36 PDT

The change looks fine. I need some Chromium person to confirm this is correct, and then I can r+ it. setXfermodeMode is about the worst method name ever. I'm surprised Skia is moving from "PorterDuffMode" which actually made some sense, to "XfermodeMode" which is just silly. ;)

Mike Reed

Comment 3 2009-06-24 14:01:03 PDT

LGTM

Nico Weber

Comment 4 2009-06-24 14:01:48 PDT

Created attachment 31809 [details] Fill in bug, reviewer, and email fields

Eric Seidel (no email)

Comment 5 2009-06-24 14:04:03 PDT

Comment on attachment 31809 [details] Fill in bug, reviewer, and email fields You don't generally fill in the reviewer. The committer will do that (or the commit script will).

Eric Seidel (no email)

Comment 6 2009-06-24 14:10:23 PDT

Committing to http://svn.webkit.org/repository/webkit/trunk ... M WebCore/ChangeLog M WebCore/platform/graphics/skia/GraphicsContextSkia.cpp M WebCore/platform/graphics/skia/ImageBufferSkia.cpp M WebCore/platform/graphics/skia/ImageSkia.cpp M WebCore/platform/graphics/skia/PlatformContextSkia.cpp M WebCore/platform/graphics/skia/PlatformContextSkia.h M WebCore/platform/graphics/skia/SkiaUtils.cpp M WebCore/platform/graphics/skia/SkiaUtils.h Committed r45103 http://trac.webkit.org/changeset/45103

Dimitri Glazkov (Google)

Comment 7 2009-06-24 16:27:24 PDT

Dudes, come on -- not cool. We've been trying to get the integration builder green for the last 3 days so that abarth and japhet could land their patches, and now this ... http://build.chromium.org/buildbot/waterfall.fyi/builders/Webkit%20(webkit.org)/builds/6294

Eric Seidel (no email)

Comment 8 2009-06-24 16:38:23 PDT

I'm happy to roll it out. Or you're welcome to Dimitri. Your call.

Dimitri Glazkov (Google)

Comment 9 2009-06-24 16:55:03 PDT

Apologies for being a bad sport. This is being taken care of downstream as we speak.

Note You need to log in before you can comment on or make changes to this bug.