Summary: | Allow custom memory allocation control for JavaScriptCore's Register class | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Zoltan Horvath <zoltan> | ||||||
Component: | JavaScriptCore | Assignee: | Nobody <webkit-unassigned> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | ||||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | PC | ||||||||
OS: | Linux | ||||||||
Bug Depends on: | 26686 | ||||||||
Bug Blocks: | |||||||||
Attachments: |
|
Description
Zoltan Horvath
2009-06-24 05:10:52 PDT
Created attachment 31782 [details]
proposed patch
Comment on attachment 31782 [details]
proposed patch
Explicit qualification by WTF:: should not be necessary. The pattern in WTF is that we put "using" statements into the files. It's a bit unusual for C++ code but I've been convinced by the other WTF developers that it's the right pattern. So we should patch FastAllocBase to include:
using WTF::FastAllocBase;
And call the class just FastAllocBase everywhere we use it.
Created attachment 31793 [details]
updated proposed patch
I've filed a bug #26686 with FastAllocBase.h modifications and unnecessary WTF:: removes. I've updated my uploaded bugs also: bug #26676 ; bug #26677 and this also. Comment on attachment 31793 [details]
updated proposed patch
r=me
Committing to http://svn.webkit.org/repository/webkit/trunk ... M JavaScriptCore/ChangeLog M JavaScriptCore/interpreter/Register.h Committed r45121 http://trac.webkit.org/changeset/45121 This patch need a fix to build: http://trac.webkit.org/changeset/45128 |