| Summary: | hover over table rows causes the whole table to repaint | ||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Ojan Vafai <ojan> | ||||||||||||||
| Component: | Layout and Rendering | Assignee: | Dave Hyatt <hyatt> | ||||||||||||||
| Status: | RESOLVED FIXED | ||||||||||||||||
| Severity: | Normal | CC: | aboxhall, apinheiro, cfleizach, commit-queue, dmazzoni, esprehn+autocc, glenn, hyatt, jchaffraix, jcraig, jdiggs, kondapallykalyan, mario, samuel_white, simon.fraser | ||||||||||||||
| Priority: | P2 | ||||||||||||||||
| Version: | 528+ (Nightly build) | ||||||||||||||||
| Hardware: | Mac | ||||||||||||||||
| OS: | OS X 10.5 | ||||||||||||||||
| Attachments: |
|
||||||||||||||||
|
Description
Ojan Vafai
2009-06-23 14:25:31 PDT
Created attachment 31737 [details]
Test case
Load this test case and hover over the rows with QuartzDebug. The whole table repaints.
dhyatt: IntRect RenderTableRow::clippedOverflowRectForRepaint(RenderBoxModelObject* repaintContainer)
dhyatt: {
dhyatt: // For now, just repaint the whole table.
dhyatt: // FIXME: Find a better way to do this, e.g., need to repaint all the cells that we
dhyatt: // might have propagated a background color into.
dhyatt: RenderTableRow.cpp
dhyatt: ojan: it's basically not that hard to fix... just spanning cell issue
dhyatt: ojan: can't just naively invalidate only the row
dhyatt: since the bgcolor of the row may be painted in a spanning cell
[SNIP]
dhyatt: ojan: it is lame
dhyatt: ojan: should be fixed
Created attachment 241066 [details]
Patch
Patch just for EWS.
Created attachment 241072 [details]
Archive of layout-test-results from webkit-ews-02 for mac-mountainlion
The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-02 Port: mac-mountainlion Platform: Mac OS X 10.8.5
Created attachment 241077 [details]
Archive of layout-test-results from webkit-ews-09 for mac-mountainlion-wk2
The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-09 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.5
Created attachment 241353 [details]
Patch
Comment on attachment 241353 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=241353&action=review > Source/WebCore/rendering/RenderTableCell.h:220 > + virtual LayoutRect clippedOverflowRectForRepaint(const RenderLayerModelObject* repaintContainer) const override; Did you mean to move this.... > Source/WebCore/rendering/RenderTableCell.h:-238 > - virtual LayoutRect clippedOverflowRectForRepaint(const RenderLayerModelObject* repaintContainer) const override; ... from here? Comment on attachment 241353 [details]
Patch
Please make a test that dumps repaint rects instead.
Created attachment 241429 [details]
Patch
Fixed in r176124. |