Bug 26660 – Chrome: Rotated complex text (Hindi) isn't vertically aligned properly

• Component: Layout and Rendering
• Status: RESOLVED FIXED

[Jungshik Shin]

When webkit-transform:rotate is applied, the vertical alignment of complex text is wrong.

It's http://crbug.com/9065

One line patch coming up

[Jungshik Shin]

Created attachment 34863 [details]
patch 

I have yet to generate Windows test results.

[Jungshik Shin]

Comment on attachment 34863 [details]
patch 

Somehow my attempt to build Webkit on Windows keeps failing (I'll figure it out). In the meantime, if it's ok to check this in without expected results on Windows, I'd like get this reviewed and land it.

[Eric Seidel (no email)]

Comment on attachment 34863 [details]
patch 

Gonna trust you on this one.  cq- because you'll have to pull the windows results off the windows bot after landing and land them in a second commit.

[Adam Barth]

Unassigning from Jungshik because he's not a committer according to http://trac.webkit.org/wiki/WebKit%20Team

[Eric Seidel (no email)]

According to my email logs, Jungshik told me he mailed his committer paperwork to Apple on May 26th.  So I expect he is a committer by now.  He does need to add his name to the wiki and
http://trac.webkit.org/browser/trunk/WebKitTools/Scripts/modules/committers.py
however.

[Brian Weinstein]

Is this supposed to have Windows specific results? It has been failing since it has been committed.

[Brett Wilson (Google)]

I think so. Jungshik, can you grab (or talk to somebody to get) Safari Window results checked in?

[Brian Weinstein]

I can take care of them, I just wasn't sure why they were necessary, but if it's agreed they are, I can get them up there in a couple minutes.

[Brian Weinstein]

Created attachment 39623 [details]
Updated Windows Results

[Darin Adler]

Why does the title of this say "Chrome"? Does this not affect other WebKit browsers?

[Eric Seidel (no email)]

Comment on attachment 39623 [details]
Updated Windows Results

Rubber-stamp = me.  Doesn't this need a .png expected file too?

[Brian Weinstein]

Windows results have been landed. I don't know how to get a png, because we don't do pixel tests on Windows (maybe Chromium does).

[Eric Seidel (no email)]

I could have sworn we had pixel results on windows, no?

Also, can we close this bug then if the results are landed?  Or is there more work to do here?

And yes, Chromium has pixel results for all platforms to my knowledge.

[Brian Weinstein]

From the WebKit end we can close this bug. I'm not sure about the Chromium side though, but this is already filed in crbug.com, so, I'll just close it here.