Bug 26660 - Chrome: Rotated complex text (Hindi) isn't vertically aligned properly
Summary: Chrome: Rotated complex text (Hindi) isn't vertically aligned properly
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Windows XP
: P2 Normal
Assignee: Nobody
Depends on:
Reported: 2009-06-23 14:10 PDT by Jungshik Shin
Modified: 2009-09-18 11:57 PDT (History)
5 users (show)

See Also:

patch (97.52 KB, patch)
2009-08-14 11:24 PDT, Jungshik Shin
eric: review+
eric: commit-queue-
Details | Formatted Diff | Diff
Updated Windows Results (3.49 KB, patch)
2009-09-15 16:55 PDT, Brian Weinstein
eric: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jungshik Shin 2009-06-23 14:10:37 PDT
When webkit-transform:rotate is applied, the vertical alignment of complex text is wrong.

It's http://crbug.com/9065

One line patch coming up
Comment 1 Jungshik Shin 2009-08-14 11:24:50 PDT
Created attachment 34863 [details]

I have yet to generate Windows test results.
Comment 2 Jungshik Shin 2009-08-25 14:56:50 PDT
Comment on attachment 34863 [details]

Somehow my attempt to build Webkit on Windows keeps failing (I'll figure it out). In the meantime, if it's ok to check this in without expected results on Windows, I'd like get this reviewed and land it.
Comment 3 Eric Seidel (no email) 2009-09-01 00:37:14 PDT
Comment on attachment 34863 [details]

Gonna trust you on this one.  cq- because you'll have to pull the windows results off the windows bot after landing and land them in a second commit.
Comment 4 Adam Barth 2009-09-06 21:52:07 PDT
Unassigning from Jungshik because he's not a committer according to http://trac.webkit.org/wiki/WebKit%20Team
Comment 5 Eric Seidel (no email) 2009-09-08 06:05:46 PDT
According to my email logs, Jungshik told me he mailed his committer paperwork to Apple on May 26th.  So I expect he is a committer by now.  He does need to add his name to the wiki and
Comment 6 Brian Weinstein 2009-09-15 16:30:40 PDT
Is this supposed to have Windows specific results? It has been failing since it has been committed.
Comment 7 Brett Wilson (Google) 2009-09-15 16:43:02 PDT
I think so. Jungshik, can you grab (or talk to somebody to get) Safari Window results checked in?
Comment 8 Brian Weinstein 2009-09-15 16:44:04 PDT
I can take care of them, I just wasn't sure why they were necessary, but if it's agreed they are, I can get them up there in a couple minutes.
Comment 9 Brian Weinstein 2009-09-15 16:55:29 PDT
Created attachment 39623 [details]
Updated Windows Results
Comment 10 Darin Adler 2009-09-15 17:00:10 PDT
Why does the title of this say "Chrome"? Does this not affect other WebKit browsers?
Comment 11 Eric Seidel (no email) 2009-09-18 11:52:33 PDT
Comment on attachment 39623 [details]
Updated Windows Results

Rubber-stamp = me.  Doesn't this need a .png expected file too?
Comment 12 Brian Weinstein 2009-09-18 11:53:40 PDT
Windows results have been landed. I don't know how to get a png, because we don't do pixel tests on Windows (maybe Chromium does).
Comment 13 Eric Seidel (no email) 2009-09-18 11:56:30 PDT
I could have sworn we had pixel results on windows, no?

Also, can we close this bug then if the results are landed?  Or is there more work to do here?

And yes, Chromium has pixel results for all platforms to my knowledge.
Comment 14 Brian Weinstein 2009-09-18 11:57:48 PDT
From the WebKit end we can close this bug. I'm not sure about the Chromium side though, but this is already filed in crbug.com, so, I'll just close it here.