Bug 26656

Summary:

[Chromium] Fix crash with inherited font-size in <option>

Product:

WebKit

Reporter:

Adam Langley <agl>

Component:

Layout and Rendering

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

adele

Priority:

Version:

528+ (Nightly build)

Hardware:

OS:

All

Attachments:

Description	Flags
patch	none
patch	eric: review+

Description Adam Langley 2009-06-23 13:22:34 PDT

In r42597 (https://bugs.webkit.org/show_bug.cgi?id=25244), I changed the <select> handing for Chromium to fix a rendering bug. However, although the font-size is correctly ignored, getRowHeight wasn't updated and so was calculating the height of the rows in an inconsistent manner. This can lead to a crash.

http://code.google.com/p/chromium/issues/detail?id=14810

Comment 1 Adam Langley 2009-06-23 13:23:53 PDT

Created attachment 31729 [details]
patch

Comment 2 Adam Langley 2009-06-23 13:25:52 PDT

Created attachment 31730 [details]
patch

Wrong bug link, should be http://code.google.com/p/chromium/issues/detail?id=14853

Comment 3 Eric Seidel (no email) 2009-06-23 17:40:33 PDT

Comment on attachment 31730 [details]
patch

If you're intending the test change to test the crash, you need to add a comment to both the test and the ChangeLog.  Since you're a committer, you can do that when you land.

Is it not possible to test this change with LayoutTest instead of a manual-test?

Comment 4 Adam Langley 2009-06-23 19:34:23 PDT

> Is it not possible to test this change with LayoutTest instead of a
> manual-test?

I tried all manner of window.eventSender ticks to try and get it to trigger the crash, but none of them worked. Testing doesn't work very well with <selects>.